Fixes #1804 bugged icon positioning in sprite #1805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! |
|
@stil, you could also remove the unused transparent background at the bottom of the sprite. |
|
5 bytes less in file size doesn't make any difference. |
|
make it properly when you have already spent time for fixing this :) |
Correcting icon position by one pixel doesn't make much difference for me either, but I don't say it's not worth including it. Cutting off the bottom is a very simple change, so I don't see why not to save these "5 bytes" when you have already done other modifications to the file. |
|
@stil - could you fix this PR? |
Stefan-MyBB
pushed a commit
that referenced
this pull request
Mar 17, 2015
Fixes #1804 bugged icon positioning in sprite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.