New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2237 Round corners in child tables inconsistent #2249
Conversation
SvePu
commented
Oct 18, 2015
- Defined the desired CSS rule only for first child of tborder class.
- Changed the version number of css3.css to 1807
It works in this case, but it's unfortunately not a proper fix. I'm sure this CSS rule was added for a reason and changing it to affect only tables which are first children may break rounded borders in some other table(s). EDIT: and your solution won't of course also work if the table is the first child of the The main issue here is something else - Invisible bottom borders can/should be fixed that way too by applying the same code to .tborder tbody tr:last-child td {
border-bottom: 0;
} |
You're right @Destroy666x Now I've tested it with different trow colors for a better view. The new solution is: .tborder tbody tr:last-child > td {
border-bottom: 0;
}
.tborder tbody tr:last-child > td:first-child {
-moz-border-radius-bottomleft: 6px;
-webkit-border-bottom-left-radius: 6px;
border-bottom-left-radius: 6px;
}
.tborder tbody tr:last-child > td:last-child {
-moz-border-radius-bottomright: 6px;
-webkit-border-bottom-right-radius: 6px;
border-bottom-right-radius: 6px;
} Could you test it please, if it's OK than I'll modify the PR |
Should be ok to add |
Modified PR in afa0aaf |
Ok, thanks. |
Fixes #2237 Round corners in child tables inconsistent