Fixes #1774 #2624
Merged
Fixes #1774 #2624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 7, 2017 15:34
|
@mybb/sqa can someone take a look at this? Thanks. |
|
Tested. Working fine. |
Shade-
reviewed
Feb 3, 2017
| if(strpos($quoted_post['username'], '"') !== false) | ||
| { | ||
| $quote_char = "'"; | ||
| } |
There was a problem hiding this comment.
Just one styling thing, wouldn't be better to add a newline after this bracket?
There was a problem hiding this comment.
No problem. I'll add it after work today.
|
@Shade- that should have this ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1774 where single quotes were used to quote the user name without checking
to see if the user name contains single quotes. If it does, this causes
the quote MyCode to fail.