Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace <acronym> with <abbr> - follow HTML5 standards #2819

Merged
merged 3 commits into from Aug 7, 2017
Merged

Replace <acronym> with <abbr> - follow HTML5 standards #2819

merged 3 commits into from Aug 7, 2017

Conversation

Eldenroot
Copy link
Contributor

@Eldenroot Eldenroot commented Aug 6, 2017 •
edited

@Starpaul20
Copy link
Member

Starpaul20 commented Aug 6, 2017 •
edited

If we're going to change any <acronym> tags with <abbr>, these should also be changed:

https://github.com/mybb/mybb/blob/feature/inc/languages/english/member.lang.php#L90
https://github.com/mybb/mybb/blob/feature/inc/languages/english/usercp.lang.php#L180

@Eldenroot
Copy link
Contributor Author

@PaulBender - I am sorry, I missed them. I will fix my PR ASAP. Thank you!

@Eldenroot
Copy link
Contributor Author

@PaulBender @euantorano and others, fixed :)

@Shade- Shade- merged commit 2118c41 into mybb:feature Aug 7, 2017
@Eldenroot Eldenroot deleted the patch-2 branch August 7, 2017 16:02
@Stefan-MyBB Stefan-MyBB added this to the 1.8.13 milestone Aug 7, 2017
@Stefan-MyBB Stefan-MyBB added b:1.8 Branch: 1.8.x t:enhancement Type: Enhancement. Contains minor improvements labels Aug 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
b:1.8 Branch: 1.8.x t:enhancement Type: Enhancement. Contains minor improvements
Projects
None yet
Milestone
1.8.13
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Eldenroot @Starpaul20 @Stefan-MyBB @Shade-