Fixes #2067 Attachment Usage Information Improvement #3120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splitted the language variable to use as necessary.
Changed / added variables.
Fine tuned 'usercp_attachments' Added new template 'post_attachments_viewlink' to hold attachment statistics page link.
Updated existing and added link to view attachment stats page (separate template).
Updated existing and added link to view attachment stats page (separate template).
Fine tuning ...
Shade-
reviewed
Apr 14, 2018
| @@ -12035,7 +12036,7 @@ if(use_xmlhttprequest == "1") | |||
| </tr> | |||
| <tr> | |||
| <td class="trow2" width="40%"><strong>{$lang->attachstats_spaceused}</strong></td> | |||
| <td class="trow2" width="60%">{$friendlyusage} ({$percent})</td> | |||
| <td class="trow2" width="60%">{$friendlyusage}</td> | |||
There was a problem hiding this comment.
If removed completely, you can remove attachments_usage_percent too, because then there's only one reference to it (attachments_usage_quota)
There was a problem hiding this comment.
Modified attachments_usage_percent to hold required space and parentheses.
Hard coded space removed from usercp.php
Done.
Space added to language
Hardcoded space removed.
Removed unnecessary blank value assignment
Sama34
reviewed
Apr 14, 2018
| @@ -291,7 +291,8 @@ | |||
| $l['date_uploaded'] ="Posted"; | |||
| $l['no_attachments_selected'] = "You did not select any attachments to delete."; | |||
| $l['attachments_deleted'] = "The selected attachments have been successfully deleted.<br />You will be now redirected to the attachments manager."; | |||
| $l['attachments_usage_quota'] = "- Using {1} of {2} ({3}) in {4} Attachments"; | |||
| $l['attachments_usage_quota'] = "- Using {1} of {2} in {3} Attachments"; | |||
| $l['attachments_usage_percent'] = "( {1}%)"; | |||
There was a problem hiding this comment.
Is that space intentional ?
There was a problem hiding this comment.
Yep. required while the % is being appended to the usage size ...
Just moved it out of usercp.php, as shade instructed to avoid hardcoding and placed in language.
There was a problem hiding this comment.
Oh wait, misplaced the space. Revising now ...
'attachments_usage_percent'
... for $percent
Eldenroot
pushed a commit
to Eldenroot/mybb
that referenced
this pull request
May 8, 2018
* Attachment status language update. Splitted the language variable to use as necessary. * Attachment status update Changed / added variables. * Attachment usage template changes Fine tuned 'usercp_attachments' Added new template 'post_attachments_viewlink' to hold attachment statistics page link. * Attachment usage updated Updated existing and added link to view attachment stats page (separate template). * Attachment usage updated Updated existing and added link to view attachment stats page (separate template). * Modified attachment statistics page Fine tuning ... * Comment incorporation Space added to language * Comment incorporation Hardcoded space removed. * $percent updated Removed unnecessary blank value assignment * Space placing revised 'attachments_usage_percent' * Refined repeat assignment ... for $percent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2067
Didn't modify function
get_friendly_size( )as it may be designed this way to use at somewhere else...Changes: