Fixes #3139 Attachment: a bug and a mod to allow multi-attachment selection

[Sama34]

Fixes #3139 Attachment: a bug and a mod to allow multi-attachment selection

Please review.

[SvePu]

@Sama34 Thx for this nice fix, but you'll get a MySql syntax error on editpost because $attachwhere is empty

[Eldenroot]

@SvePu - thx for your input!
@Sama34 - good job! Better and cleaner approach than mine was 👍 can you please fix last issue?

[SvePu]

@Sama34 - also I get an empty($_POST) error when summary of all selected file sizes is greater than php post_max_size. May be we need a size check before start uploading

Could someone confirm this?

[euantorano]

Minor change needed with the template version, and would be good if we could get the edit post issue. I'm not sure about the best way to handle the other issue mentioned by @SvePu - a size check might be easiest.

[euantorano]

This template needs the version bumping to 1816.

[SvePu]

@Sama34
I fixed the issue by replacing in editpost.php:

$ret = add_attachments($pid, $forumpermissions, $attachwhere, "editpost");

with:

$ret = add_attachments($pid, $forumpermissions, "pid='{$pid}'", "editpost");

@euantorano
I use some litte JavaScript for this size check - if JavaScript is disabled in browser the multiupload option will be changed into a single upload.

[euantorano]

@SvePu That sounds like a good option to me.

[SvePu]

Maybe someone with more knowledge in JavaScript could integrate something like this into jscripts/post.js
The vars for max_upload_size and post_max_size we could get over:

ini_get('upload_max_filesize');

and

ini_get('post_max_size');

[Eldenroot]

@Sama34 - can you please incorporate fixes above? I tested this PR and seems to be fine except these two things. Thank you'

[Ben-MyBB]

@Sama34 ping

[effone]

Can you please look at the PR @Sama34 ? Seems to be the last PR for 1.8.16 so far ...

[Eldenroot]

Or is there anybody who can merge this and add the requested chnages in next PR?

[effone]

May be @SvePu can create an extended part of this and then we can merge both back to back.
He has already worked on it. Studying the whole PR for extending will take time for me.

[SvePu]

@effone
I use this small JS inline script to check upload size and file count before fire up the upload. Maybe someone could integrate something like this into post.js to call it on click at submit button.

<script type="text/javascript">	
	$(function(){
		document.getElementById("file").setAttribute("multiple","multiple");
		$("input[type='submit']").click(function(){
			var fileUpload = $("input[type='file']");
			if (parseInt(fileUpload.get(0).files.length)>{$php_max_file_uploads}){
				alert("Du kannst maximal {$php_max_file_uploads} Dateien gleichzeitig hochladen - Führe wenn nötig mehrere Durchgänge aus.");
				document.getElementById("file").value="";
				return false;
			}
			var totalSize = 0;
			fileUpload.each(function() {
				for (var i = 0; i < this.files.length; i++) {
					totalSize += this.files[i].size;
				}
			});
			var valid = totalSize <= {$php_max_upload_size};
			if (!valid) {
				alert('Die hochzuladenen Dateien haben eine Gesamtgröße über {$php_max_upload_size_mb} - bitte führe wenn nötig mehrere Durchgänge aus.');
				document.getElementById("file").value="";
				return false;
			}
		});
	});
</script>

Sorry....the alert info is in German language ;)

[Eldenroot]

Is there anybody who can make a new PR with JS script above? I would like to but my JS knowledge is almost zero :(

[euantorano]

@Eldenroot This PR won't be making it into 1.8.16 unfortunately, it'll have to wait until .17.

[Eldenroot]

I use this "new feature" on my board (without JS part), I applied changed from SvePu, working fine. Is there anybody who can take care of JS part and add it inside post.js? @Sama34

[euantorano]

Superseded by #3373.