Fixes #3170 MySQL error with strict mode if message too long - Extended #3286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chack1172
suggested changes
Jun 26, 2018
inc/datahandlers/post.php
Outdated
| $limit = max($limit, $dblimit); | ||
| } | ||
|
|
||
| if(strlen($post['message']) > $limit && (!is_moderator($post['fid'], "", $post['uid']) || $limit == $dblimit)) |
There was a problem hiding this comment.
This condition is not working well. If an administrator/moderator sends a message longer than $dblimit, this condition lets him post it because $limit is the post limit and not the db limit. You should remove the is_moderator condition here and move it where is $limit declared.
There was a problem hiding this comment.
I suggest you to change it with this:
if($limit > $dblimit)
{
$limit = $dblimit;
}
if(strlen($post['message']) > $limit)
{| $this->set_error("message_too_long", array($mybb->settings['maxmessagelength'], strlen($post['message']))); | ||
| return false; | ||
| } | ||
| $limit = (int)$mybb->settings['maxmessagelength']; |
There was a problem hiding this comment.
Here you should add the is_moderator condition:
if(!is_moderator($post['fid'], '', $post['uid']))
{
$limit = (int)$mybb->settings['maxmessagelength'];
}
else
{
$limit = 0;
}There was a problem hiding this comment.
Logic updated. Thanks for review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covered field types for MySQL
Revised settings description.