fixes #3430 ACP settings search option hardcoded only for english language #3438
Conversation
… language. Fixes issue where ACP settings search option, has searched directly DB data (which is in english) without considering translation. Because of this, ACP options search feature didnt worked for any other language than english.
|
fixes #3430 |
|
@avril-gh I have a little time to test this week. Make sure I have steps to reproduce correct:
|
WildcardSearch
added
the
s:confirmed
|
Nevermind, @avril-gh Confirmed on MyBB 1.8.19 |
|
If admin use in ACP another language than english, he obviously will name options in his own language, but since search box directly query on DB tables which are in english. he will not find the option he is looking for. The solution is to not search directly on DB tables (like now) but instead, fetch them and search them localy while applying translation in the fly. like usual, tested closely at each stage before submitting PR |
|
Thank you, @avril-gh. I was able to reproduce the error. Your PR solves the issue. Maybe @dvz or @euantorano will have time to merge it. |
There was a problem hiding this comment.
because of data in DB is by default hardcoded in english
1148 - we'll fetch settings
1151 - instead of searching it directly on DB
1155 - and dynamicaly translate -> search -> build and returns $cache_settings variable in exacly same format as it's expected by later logic flow, so theres no need for more changes.
|
Fixes #3430 |
avril-gh
deleted the
fixes-#3430-ACP-settings-search-option-hardcoded-only-for-english-language-
branch
Fixes issue where ACP settings search option, has searched directly DB data (which is in english) without considering translation. Because of this, ACP options search feature didnt worked for any other language than english.