Fixes #3486 Missing Moderation Notices

[effone]

Attempt to fix #3486

[Eldenroot]

Great, testing since yesterday, seems to be fine. I had been using plugin for that. Thank you!

[effone]

Thanks for testing @Eldenroot, There is a very neat-pick issue I have observed with this PR but failed to find the root cause, is an additional space after each link.

I have cross-checked templates, used trim() but no luck. That may be my cluttered experiment-exhausted code base. Can you confirm and / or try to find the root cause?

[Eldenroot]

I will try to reproduce in 5 hours, back in my office right now. Maybe sometjing similar with board stats (online members) in footer bug which was solved in 1.8.17 IIRC?

[effone]

Okay I have found the issue. Its the new line inserted by template class.

if($htmlcomments)
{
	if($mybb->settings['tplhtmlcomments'] == 1)
	{
		$template = "<!-- start: ".htmlspecialchars_uni($title)." -->\n{$template}\n<!-- end: ".htmlspecialchars_uni($title)." -->";
	}
	else
	{
		$template = "\n{$template}\n";
	}
}

If I remove all \n from it issue gets resolved. I don't know how to handle this.
@euantorano ?

[effone]

Alright I have fixed it. There was a parameter $htmlcomments for get() method that required to be set to false. Love MyBB.

[euantorano]

Nice catch @effone!