Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #2440 Image paste from clipboard support #3808

Merged
merged 1 commit into from Sep 28, 2019

Conversation

effone
Copy link
Member

@effone effone commented Sep 27, 2019

Resolves #2440

Image paste from clipboard support added.

@euantorano euantorano merged commit 4c5451a into mybb:feature Sep 28, 2019
@effone effone deleted the paste-img branch September 28, 2019 16:28
@dvz
Copy link
Contributor

dvz commented Nov 5, 2019

Do we want inline image support in the long run (rather than handling them as attachments client-side when pasted/dropped)? Best to go over this before adding support for formats that may be dropped later @mybb/developers

@euantorano
Copy link
Member

euantorano commented Nov 5, 2019

IMO this is what should happen:

  1. Image pasted/dropped in to editor
  2. JS detects this, and starts an AJAX request to create an attachment
  3. If attachment added, atatchment is inserted in post/thread/PM (note: PMs don't support attachments in 1.8...)

In the long run, base 64 content for what could be large (several MB) image files inside the posts table would only cause headaches.

However, implementing the above wouldn't be finished by 1.8.22 unless we want to delay the release by several weeks.

I wouldn't mind stripping out the base 64 support for now and creating a new issue for 1.8.23 to implement the above flow. Or we can leave it as is for 1.8.22 and implement the above for 1.8.23 - only problem will be any posts created between 1.8.22 and 1.8.23 could have inline base 64 image data.

@dvz
Copy link
Contributor

dvz commented Nov 5, 2019

Yes, we could revert this one to avoid potential backtracking on MyCode support (individual forums could still install a plugin for this, which should be simple to create).

@euantorano
Copy link
Member

I think that would be for the best for now.

dvz added a commit that referenced this pull request Nov 12, 2019
dvz added a commit that referenced this pull request Nov 12, 2019
lairdshaw pushed a commit to lairdshaw/mybb that referenced this pull request Oct 11, 2021
lairdshaw pushed a commit to lairdshaw/mybb that referenced this pull request Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nothing pasted when pasting an file into the editor
3 participants