Fixes #4100 Insecure connection used for Stop Forum Spam API #4101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4100
Changing to HTTPS worked fine in my tests in 5.6 and 7.4 with PHP using cURL 7.58.0, using
stream_context_createandfsockopen. I didn't even need to add theSNI_enabledparameter in the stream options.I couldn't find any stats on cURL versions used by PHP installs to see about SNI support but since mybb.com is also behind Cloudflare using SNI the same problem is present for the upgrade check. So I think this change is safe to make.