Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4238 Add commit hook to attachments forum module (ACP) #4239

Merged
merged 1 commit into from Jan 30, 2021
Merged

Fix #4238 Add commit hook to attachments forum module (ACP) #4239

merged 1 commit into from Jan 30, 2021

Conversation

Sama34
Copy link
Contributor

@Sama34 Sama34 commented Jan 14, 2021

Fix #4238 Add commit hook to attachments forum module (ACP)

@Ben-MyBB
Copy link
Member

Note: We would need to add this onto the hooks page https://docs.mybb.com/1.8/development/plugins/hooks/

@euantorano
Copy link
Member

euantorano commented Jan 15, 2021 via email

@Sama34
Copy link
Contributor Author

Sama34 commented Jan 16, 2021

I think I will add more hooks to this module, just spare me a couple of days for reviewing so.

@Sama34
Copy link
Contributor Author

Sama34 commented Jan 24, 2021

It is currently complicate to tweak the filter options. There are other places where hooks could be useful which I will add.

@euantorano
Copy link
Member

@euantorano If the page is automatically generated than there should be no need to trigger regeneration manually as new version will trigger regeneration automatically, am I right?

I believe that part of our release workflow is to regenerate the page, but I don’t think it gets triggered automatically.

@euantorano
Copy link
Member

I’m going to merge this as is for now, and we can open more PRs for any other hooks.

@euantorano euantorano merged commit 5d5ab14 into mybb:feature Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add commit hook to attachments forum module (ACP)
3 participants