Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined issues #4594

Merged
merged 20 commits into from
Dec 5, 2022
Merged

Fix undefined issues #4594

merged 20 commits into from
Dec 5, 2022

Conversation

dvz
Copy link
Member

@dvz dvz commented Oct 5, 2022

Resolves #4593

dvz and others added 20 commits October 5, 2022 19:17
…Hardcoded Guest usergroup ID (1) is used.
@dvz dvz merged commit 4d88a6f into mybb:feature Dec 5, 2022
@yuliu
Copy link
Member

yuliu commented Dec 5, 2022

Sorry about this super belated reply. There are several side notes about some commits in the PR, for reference for future development.

On commit d2445ad

  • Messages or UI texts may be further refined for the consistency when displaying deleted users across the popup window and the opened sent message page.

On commit b253d84

  • For a thread/reply is posted by a guest, the postusername field may be empty if the guest chose not to supply a username. So, the fix may further address showing an indicative "Guest" string from a language entry.

On commit a82fdaa

  • Hardcoded ID for the Guest usergroup should be avoid, really.

On commit 7ee0ec1

  • As the original issue comment suggests, the guest user avatar, $post['useravatar'], may be considered.

On commit 973940e

  • Although the undefined warning things is fixed for this one, the fixed variable and variables that use it are never used in those pages.

On Commit 15b90cb

  • Admit it, the relevant code around this fix that counts the star images for either usergroup titles or post count titles is a mess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix PHP 8 compatibility issues since version 1.8.31
2 participants