Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes PHP 8 compatibility issues. #4613

Merged
merged 20 commits into from
Apr 29, 2023
Merged

Fixes PHP 8 compatibility issues. #4613

merged 20 commits into from
Apr 29, 2023

Commits on Dec 15, 2022

  1. Fixes mybb#4602 undefined $usersbrowsing in eval()'d code (92) in .…

    …/showthread.php(1617).
    yuliu committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    967c0d9 View commit details
    Browse the repository at this point in the history
  2. Fixes undefined variables $search_thread and $forumjump in `showt…

    …hread.php` and `forumdisplay.php`, reported in mybb#4530 (comment) .
    yuliu committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    cc02c33 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Configuration menu
    Copy the full SHA
    bf9ae2d View commit details
    Browse the repository at this point in the history
  2. Fixes undefined variable $numpolloptions in eval()'d code (8) in `n…

    …ewthread.php` (1093).
    yuliu committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    6a7bf76 View commit details
    Browse the repository at this point in the history
  3. Fixes PHP warning of trying to access array offset on value of type n…

    …ull in `usercp.php` (L3643).
    yuliu committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    9178cda View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2022

  1. Configuration menu
    Copy the full SHA
    3b3ddc4 View commit details
    Browse the repository at this point in the history
  2. Fixes PHP warnings of undefined array key "fragment" and undefined ar…

    …ray key 0 in `inc/class_parser.php` (L1494, L1587).
    yuliu committed Dec 17, 2022
    Configuration menu
    Copy the full SHA
    1fcc68e View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2022

  1. Fixes various PHP warnings in thread/post moderations:

     - Delayed moderation:
        - Undefined variable `$thread` in `moderation.php` (L423).
        - Trying to access array offset on value of type null in `moderation.php` (L423).
    
     - Soft delete thread(s):
        - Undefined array key "num_threads" in `inc/class_moderation.php` (L3798).
        - Undefined array key "num_threads" in `inc/class_moderation.php` (L3798).
    
     - Restore (soft-deleted) thread(s):
        - Undefined array key "num_threads" in `inc/class_moderation.php` (L3639).
        - Undefined array key "num_threads" in `inc/class_moderation.php` (L3639).
    
     - Move post(s):
        - Undefined variable `$return_url` in eval()'d code (L27) in `moderation.php` (L2669).
    
     - Moving post(s):
        - Undefined array key 1 in `moderation.php` (L2697).
    yuliu committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    6b2fa22 View commit details
    Browse the repository at this point in the history
  2. Fixes various PHP warnings in thread moderations:

     - Approve thread(s):
        - Undefined array key XXX in `inc/class_moderation.php` (L437).
        - Undefined array key "num_posts" in `inc/class_moderation.php` (L437).
        - Undefined array key "num_threads" in `inc/class_moderation.php` (L504).
    
     - Similarly, unapprove thread(s).
    yuliu committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    b007a8b View commit details
    Browse the repository at this point in the history
  3. Fixes PHP warning of trying to access array offset on value of type n…

    …ull `polls.php` (L983).
    yuliu committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    2126483 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Fixes PHP warnings in AdminCP > Tools & Maintenance > System Health >…

    … UTF-8 Conversion:
    
     - Undefined array key "table" in `admin/modules/tools/system_health.php` (L441).
     - Undefined variable `$converting_table` in `admin/modules/tools/system_health.php` (L241).
     - Undefined variable `$fulltext_to_create` in `admin/modules/tools/system_health.php` (L360).
    yuliu committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    7c32e61 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2022

  1. Fixes PHP warning of undefined array key "uid", "fid", and "sortby" i…

    …n `/admin/modules/tools/modlog.php` (L313).
    yuliu committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    2fd725f View commit details
    Browse the repository at this point in the history
  2. Fixes missing $pm['options'] when sending pms in reporting contents…

    …, which results in PHP fatal error of uncaught TypeError: Argument #2 ($array) must be of type array, null given in `array_key_exists()` in `/inc/datahandler.php` (L207).
    yuliu committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    64e8476 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2022

  1. Fixes PHP warning of undefined array key "receivepms" and adds some r…

    …efinements in `send_pm()` in `inc/functions.php` (L9027).
    yuliu committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    81d9adf View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2023

  1. Fixes PHP warnings of undefined array key "uid" and "username" in `ve…

    …rify_sender()` in `inc/datahandlers/pm.php` (L149-L150), a workaround for mybb#4630 (comment) .
    yuliu committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    128f8ea View commit details
    Browse the repository at this point in the history
  2. Fixes PHP warning of undefined array key "linkto" in `inc/functions_f…

    …orumlist.php` (L490).
    yuliu committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    1c42a0a View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. Fixes PHP warnings in front-end user warning system:

     - Undefined array key "pid" in `inc/datahandlers/warnings.php` (L687) when issuing a warning from user profile page, etc.
     - Undefined variable `$last_expired` in `warnings.php` (L238) when viewing a user's warnings for their specific post.
    yuliu committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    0a81a58 View commit details
    Browse the repository at this point in the history
  2. Fixes PHP warning of undefined array key X in `inc/datahandlers/post.…

    …php` (L1213) and a typo in `inc/datahandlers/post.php` (L1228).
    yuliu committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    b153eb7 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. Configuration menu
    Copy the full SHA
    93f1864 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2023

  1. Configuration menu
    Copy the full SHA
    d0af363 View commit details
    Browse the repository at this point in the history