Option to select by default source mode editor in usercp

[martec]

Original Thread: http://community.mybb.com/thread-154407.html

Option to select by default source mode editor in usercp

[Destroy666x]

I think you should also include the new field in inc/datahandlers/user.php -> verify_options() and insert_user()

[martec]

@Destroy666x
Thanks... Fixed.

[Destroy666x]

I browsed some other commits and I forgot one more thing - it also needs to be in ACP Edit User like here: eb45fac

Also, I don't think the if conditional for codebuttons in datahandler file is correct (it isn't even compliant with MyBB coding standards), probably should use the verify_yesno_option as in the linked commit instead.

[martec]

@Destroy666x

thanks again. Fixed.

[Sama34]

Why this has to bee an user option instead of a administrator one?

[martec]

@Sama34
for me better usercp option...
not all users want use source mode by default.
personally i don`t like idea of admin decide all thing to user.
Moreover this kind of discussion better in forum than here to view users' comments
http://community.mybb.com/thread-154407.html

[Destroy666x]

Yea, users should be able to change it as it's a personal preference.

I tested it and it works, so it can be merged. Maybe only one last small correction is needed:

"sourceeditor" => intval($mybb->input['sourceeditor']),

intval is not needed there, as I said above showcodebuttons option is introduced in a weird way that doesn't match other yes/no options. Would be nice and helpful if you could also fix showcodebuttons standard (both files - verify_yesno asnd intval) in this PR.

[martec]

@Destroy666x
done.
Check for me if all ok.

[Destroy666x]

Ok, thank you. I'll merge it since it works fine as I said.

[martec]

@Destroy666x

thank very much!
and also thanks for the help to fix this PR