This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
Fixes #42 Add breadcrumbs to User Profiles #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| namespace MyBB\Core\Http\Controllers; | |||
|
|
|||
| use DaveJamesMiller\Breadcrumbs\Manager as Breadcrumbs; | |||
There was a problem hiding this comment.
Shall we just create a sub-class of this called Breadcrumbs and save ourselves having to alias everywhere?
There was a problem hiding this comment.
Probably. But there are also some other classes we alias everywhere (all Manager and Repository classes). If we change that we should change it everywhere.
There was a problem hiding this comment.
Agreed, we don't have to do it all in one go though!
There was a problem hiding this comment.
It's always better to do it in one go ;) Otherwise we start missing things again etc.
wpillar
added a commit
that referenced
this pull request
Apr 23, 2015
Fixes #42 Add breadcrumbs to User Profiles
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#42