Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $post global for compatibility with hide mod + #321

Merged
merged 2 commits into from Jan 12, 2022

Conversation

KevinVR
Copy link
Contributor

@KevinVR KevinVR commented Jan 11, 2022

Hide mod + fetches the $post['pid'] to check whether the user has access to the hidden content. Without this global, hide mod + cannot verify access if hidden content appears as the top liked message in the user's profile.

Hide mod + fetches the $post['pid'] to check whether the user has access to the hidden content. Without this global, hide mod + cannot verify access if hidden content appears as the top liked message in the user's profile.
@Eldenroot
Copy link
Member

@lairdshaw - please can you review? Is there any side-effect? I am not sure if we should officially support third-parties plugin... Thank you

@KevinVR - thank you for your contribution.

@Eldenroot
Copy link
Member

Eldenroot commented Jan 11, 2022

OK, your Hide mod plugin is not for free, so I am against to add this into our open sources and freely available plugin! I am sorry.

Anyway feel free to add this "HIDE" feature into our plugin and send a PR :)

Copy link
Member

@Eldenroot Eldenroot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On hold.

@Eldenroot
Copy link
Member

After our discussion with @lairdshaw merged :) Thank you!

@Eldenroot Eldenroot merged commit 8707d1f into mybbgroup:master Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants