-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix custom protocol and host when API has next pages, fixes #118 #123
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While fixing the URI is a potential solution, Kong should be giving back an appropriately formed url for that "next" value, and I don't think Kongfig should necessarily have the responsibility of changing that value.
We realized that the "next" url that appears in paginated responses was Kong not giving back the correct url, and this is the temporary solution we've implemented: Solution 1 (desired solution) Solution 2 (current solution) It has almost the same configuration as the Admin API, the only difference being that this API is solely responsible for making all GET requests. As far as precedence, incoming GET requests will always be routed through this second Admin GET API instead of the original Admin API. The Admin API:
The Admin GET API:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like. all url-parts included and usage of existing url-utils. i personally prefer a function name like 'getNextUrl' instead of 'fixNext'
I am having the same problem too, it would be great if this issue gets fixed soon. |
I'll do a release tomorrow. |
Hello, Is this issue fixed with 1.5.3? Thanks |
@theoskolnik : do you happen to have a link to the issue or PR where the Kong team is tracking the following?
|
fixes #105, #118