Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting transaction doesn't work when too many 1000+ #243

Closed
Transisto opened this issue Jan 28, 2016 · 9 comments
Closed

Exporting transaction doesn't work when too many 1000+ #243

Transisto opened this issue Jan 28, 2016 · 9 comments
Assignees
Labels

Comments

@Transisto
Copy link

There is no sign that Mycelium is doing anything when I tap "export transaction".

I have an account with 1500+ transactions with important labels, I wouln't mind waiting even half a day to have Mycelium export these labels. It seems like it abandon without an error message after 200-300tx

Thank you.

@Transisto
Copy link
Author

Maybe the solution would be to export as file instead of a blob of text

@Giszmo Giszmo added the bug label Feb 25, 2016
@Giszmo
Copy link
Contributor

Giszmo commented Feb 25, 2016

#142 is somewhat related (in case somebody wants to jump at fixing this)

Here the data gets added to an intent that gets handled by whatever. If you send it to Twitter, Twitter will limit it to 140 chars. Other apps may apply other limits. The IPC should work to a limit of 1MB, which should be good for about 6000 transactions. Less if you have a lot of lables. (Please use additional HD accounts if you are such a power user. It's for your own convenience and privacy.)

As a company we have to assume that more and more people will get into the range of thousands of transactions with more and more meta data, so the export should probably be handled wie a file attachment instead of a plain text if size is really the issue.

@Transisto could you please share which phone you are using? Independently we have to try this out with thousands of transactions, too.

@Giszmo Giszmo self-assigned this Feb 26, 2016
@Giszmo
Copy link
Contributor

Giszmo commented Feb 26, 2016

I guess this will be fixed with the next release. There's still some TODOs. See patch.

csvFileBasedPatch.txt

@Transisto
Copy link
Author

Seems to be not working starting arround 800 transactions. Nowhere near
6000. On galaxy a S6
On Feb 25, 2016 15:15, "Leo Wandersleb" notifications@github.com wrote:

#142 #142 is somewhat
related (in case somebody wants to jump at fixing this)

Here
https://github.com/mycelium-com/wallet/blob/master/public/mbw/src/main/java/com/mycelium/wallet/activity/modern/ModernMain.java#L334
the data gets added to an intent that gets handled by whatever. If you send
it to Twitter, Twitter will limit it to 140 chars. Other apps may apply
other limits. The IPC should work to a limit of 1MB, which should be good
for about 6000 transactions. Less if you have a lot of lables. (Please use
additional HD accounts if you are such a power user. It's for your own
convenience and privacy.)

As a company we have to assume that more and more people will get into the
range of thousands of transactions with more and more meta data, so the
export should probably be handled wie a file attachment instead of a plain
text if size is really the issue.

@Transisto https://github.com/Transisto could you please share which
phone you are using? Independently we have to try this out with thousands
of transactions, too.


Reply to this email directly or view it on GitHub
#243 (comment)
.

@Giszmo
Copy link
Contributor

Giszmo commented Feb 26, 2016

Ok, then this change might be necessary starting at even more transactions than what you have but not fix another issue? I understood your reply as saying that you tried my patch?

I did not dig deep into the internals where the transactions get pulled from as I can now export 8000 times my three lines of transaction + header. The mail takes forever to show up on my laptop but it eventually arrives, with the data.

@Transisto
Copy link
Author

No sorry I didn't run the patch, I don't know how to compile mycelium.

On Fri, Feb 26, 2016, 10:02 Leo Wandersleb notifications@github.com wrote:

Ok, then this change might be necessary starting at even more transactions
than what you have but not fix another issue? I understood your reply as
saying that you tried my patch?

I did not dig deep into the internals where the transactions get pulled
from as I can now export 8000 times my three lines of transaction + header.
The mail takes forever to show up on my laptop but it eventually arrives,
with the data.


Reply to this email directly or view it on GitHub
#243 (comment)
.

@Giszmo
Copy link
Contributor

Giszmo commented Feb 26, 2016

Ok, don't bother. I suppose/hope this fixes your problem and didn't lose much time looking elsewhere. Just some clean-up and it's ready for the next release.

@DanielWeigl
Copy link
Contributor

Can you try if it works with 2.7.3 now?

@Transisto
Copy link
Author

It work perfectly, than you very much.

Giszmo added a commit that referenced this issue May 2, 2018
Fix for bch found dialog appearing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants