Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve getKey method performance #136

Merged
merged 7 commits into from
Feb 15, 2021
Merged

Improve getKey method performance #136

merged 7 commits into from
Feb 15, 2021

Commits on Aug 19, 2020

  1. Add getKey() return type as string

    @simPod
    simPod committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    86949d6 View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2021

  1. Merge branch 'master' into improve_getKey_performance

    @drealecs
    drealecs committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    8d8c6ec View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2021

  1. make assertValidValue private as it's not valuable to extend the API.… 

    … One can programatically call `isValid()` returning bool or just create a new instance with `from()` throwing exception
    @drealecs
    drealecs committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    0ad4363 View commit details
    Browse the repository at this point in the history

  2. cache the key value at construct changing from in_array to array_search

    @drealecs
    drealecs committed Feb 14, 2021
    Configuration menu
    Copy the full SHA
    edcc10d View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2021

  1. move key property initialization in __wakeup in case an old version i… 

    …s unserialized
    @drealecs
    drealecs committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    4f2c572 View commit details
    Browse the repository at this point in the history

  2. re-add the public static method assertValidValue

    @drealecs
    drealecs committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    b072dc2 View commit details
    Browse the repository at this point in the history

  3. optimize the from named constructor to have only one array full scan … 

    …without calling the constructor again
    @drealecs
    drealecs committed Feb 15, 2021
    Configuration menu
    Copy the full SHA
    be02f8d View commit details
    Browse the repository at this point in the history