IntentContainer.instantiate_from_disk() method does not load data for padaos regex patterns

[repodiac]

Hi,

I contributed the instantiate_from_disk() functionality some time ago (short recap: you can reuse and load trained models from disk via utilizing cached contents which have been stored externally).

Unfortunately, there is a bug I found out recently. I fixed it already with some kind of workaround. In the following I describe the details/background.

Background:

• As I already found out and noted down as comment in the source code, the padaos (https://github.com/MycroftAI/padaos) regex "compiler" has to recompile also when loading the trained models from disk.
• The current interface to this component does not allow to persist patterns to disk and reload them in the same fashion as instantiate_from_disk() does. Another code change and pull request for this project might be necessary here but that can be discussed on the padaos repo website.
• The bug is/was that line self.padaos.add_entity(name, lines) in method add_entity of intent_container.py contained empty lines - I provided an empty list via instantiate_from_disk() since for reloading/instantiating from disk no training data is (usually) necessary! In this case it is, unfortunately (due to the need to recompile patterns with padaos)
• The workaround (i.e. fix) was to provide the original training data for both entities and intents to the padaos compiler so that it can work with all the text for outputting the required patterns eventually.

Implications: If no contents for entities and intents are provided to the padas compiler, most entities embedded in intents are not detected and some intents tend to be completely wrong most of the time. So it is rather severe.

Solution: As said before, I would like to contribute the fix via another pull request. The fixed functionality has also been considered in an improved unit test (in test_container.test_instantiate_from_disk())

[repodiac]

done (merged)