Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitize --buildargs input #18

Closed
mydevpeeps opened this issue Oct 4, 2021 · 2 comments
Closed

Sanitize --buildargs input #18

mydevpeeps opened this issue Oct 4, 2021 · 2 comments
Assignees
@mydevpeeps
Labels
bug Something isn't working

Comments

@mydevpeeps
Copy link
Owner

From discord:

platformio.ini
 build_flags = 
  -DPWM_FREQUENCY=(168*10^6)/(2*255*1)

need to adjust logic of build commands to accommodate special characters and math objects.
@mydevpeeps mydevpeeps added the bug Something isn't working label Oct 4, 2021
@mydevpeeps mydevpeeps self-assigned this Oct 4, 2021
@mydevpeeps
Copy link
Owner Author

I have two options. I can either iterate multiple --buildarg flags or I can parse one big value in a quoted string... also need to accommodate for any spaces.

@mydevpeeps
Copy link
Owner Author

I have decided to have this tool configure only. Build will be separate.

mydevpeeps added a commit that referenced this issue Oct 4, 2021
@mydevpeeps
Implements #19 to remove build and make this solely a configuration t…
42a0198 
…ool. renames build-marlin.ps1 to marlin-configurator.ps1.

Cancels #2 #4 #13 #18 since they are no longer valid.
Updates README.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mydevpeeps mydevpeeps

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mydevpeeps