Fixes #1393
Merged
Fixes #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
STRICT_TRANS_TABLES fails empty values in enum fields.
This happens because InnoDB cannot drop table if some DML works with foreign table referencing it (even under FOREIGN_KEY_CHECKS=0). For --overwrite-tables we don't start DML until all table creation processed. But since this is not 100% success guarantee as a second measure we implement retry mechanism with retry_queue which collects failed tables and retries them upon JOB_SHUTDOWN. --retry-count sets maximum number of such retries (default 10). --overwrite-unsafe cancels all the above and works like before the patch. There also wrong semantics used in overwrite_table() for m_query() for TRUNCATE and DELETE. These are fixed in this commit.
--max-threads-per-table-hard removed as it does nothing more than --max-threads-per-table does. --threads value is autodetected to the number of CPUs by default. --max-threads-per-table by default is set to the value of --threads.
Leftover fix in test_case_stream
davidducos
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.