some optimisation when using --tables-list #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shihuafan
changed the title
|
Hi @shihuafan , please, request a review when you are done. |
davidducos
reviewed
Apr 3, 2024
| continue; | ||
| if (lock && !eval_regex(row[0], row[1])) |
There was a problem hiding this comment.
@shihuafan please, review my last commit about this change
shihuafan
force-pushed
the
fix/skip_log_tb
branch
from
212db9c
to
25d28f5
Compare
2. myloader support mysql regex
shihuafan
force-pushed
the
fix/skip_log_tb
branch
from
25d28f5
to
3828fcd
Compare
|
@davidducos I'm done, please review
|
davidducos
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skip dump mysql.show_log .... when using
mydumper --tables-list='mysql.%'