Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding progress for import #259

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Conversation

carlosmuller
Copy link
Contributor

This pr implements a progress for myloader, the progress is calculated in the number of data files in the folder.

close #143

@zodman
Copy link

zodman commented Jan 21, 2021

Beautiful man!! this is awesome!!! it works!

Copy link
Member

@davidducos davidducos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me and I also tested. will be merge in the next release.

@davidducos davidducos linked an issue Feb 3, 2021 that may be closed by this pull request
@davidducos davidducos merged commit 118de8b into mydumper:master Feb 3, 2021
@druud
Copy link

druud commented Feb 4, 2021

Thanks. Good to ignore all empty files.

"I generally check things like the size of files it writes, both at dumping and loading, in a second screen window."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mydumper: suggested improvements add progress for mydumper/myloader
4 participants