Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal CircleCI config #316

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Add minimal CircleCI config #316

merged 1 commit into from
Nov 30, 2021

Conversation

SuperQ
Copy link
Collaborator

@SuperQ SuperQ commented Apr 22, 2021

Add a simple build pipeline using CircleCI. This is just a first step.

This can be extended to test multiple combinations of different base
iamges, MySQL client libraries, and then integration tests with data.

Signed-off-by: SuperQ superq@gmail.com

@SuperQ
Copy link
Collaborator Author

SuperQ commented Apr 22, 2021

@davidducos, this will require someone with maintainer access to configure integration with https://circleci.com/. There's a nice free tier for open source projects.

Add a simple build pipeline using CircleCI. This is just a first step.

This can be extended to test multiple combinations of different base
iamges, MySQL client libraries, and then integration tests with data.

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ
Copy link
Collaborator Author

SuperQ commented Apr 27, 2021

Ping @davidducos, what do you think about adding this?

@davidducos
Copy link
Member

Hi @SuperQ,
I need to test it first and I didn't have much time. I will try to do it asap but not before next release which I will try to do it in 2 weeks.
Btw, if you can provide me procedure to do this, that will be awesome. I already created my account on circleci

@davidducos
Copy link
Member

@SuperQ, the other issue that I have is that MyDumper is not my repo and it is not an organization. This means that I don't have admin privileges, and I'm not allowed to create a project with MyDumper. And I don't want to branch to my account each time that I need to do a test... this is something that @maxbube and me, are already discussing. I will let you know.
Please, don't forget about the 'tutorial'! thank you!

@SuperQ
Copy link
Collaborator Author

SuperQ commented Apr 27, 2021

The CircleCI getting started guide pretty much covers it.

Basically once someone (maxbube in this case, since it's not an org project) needs to click through the integration buttons and that's it. It's pretty hands-off.

I'd be happy to help with the GitHub org stuff. I manage a bunch of that for the Prometheus monitoring project.

@SuperQ
Copy link
Collaborator Author

SuperQ commented Nov 30, 2021

Are you still interested in adding CI to this project?

@davidducos
Copy link
Member

Hi @SuperQ, yes, now that we had changed mydumper to org, I will be able to start to test it.

@SuperQ
Copy link
Collaborator Author

SuperQ commented Nov 30, 2021

You can merge this, and then activate the integration. Or if you're ok with granting me contributor access, I can help with it.

After that is complete, I can make some additional PRs to setup more tests.

@davidducos
Copy link
Member

@SuperQ,
I'm currently just as member of the org, I think that we need to change my role to owner to be able to add you, I will talk with @maxbube to allow you to be a contributor.
Meanwhile, I will approve this a test it, but YES! your help will be appreciated!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants