Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] estimate_count should not be called if it is not an integer field #375

Merged
merged 1 commit into from
Jul 12, 2021
Merged

[Fix] estimate_count should not be called if it is not an integer field #375

merged 1 commit into from
Jul 12, 2021

Conversation

davidducos
Copy link
Member

I had to move the variable assignment to inside the switch, as estimate_count only needs to be called when the field is an integer type

@davidducos davidducos added the Fix label Jul 12, 2021
@davidducos davidducos linked an issue Jul 12, 2021 that may be closed by this pull request
[BUG / mydumper] Unable to get estimates for db.table: Unknown column 'fiels-value' in 'where clause' #374
Closed
@davidducos davidducos added this to the Release 0.10.9 milestone Jul 12, 2021
@davidducos davidducos merged commit 365fee9 into master Jul 12, 2021
@davidducos davidducos linked an issue Jul 15, 2021 that may be closed by this pull request
[BUG] adding --rows to command triggers unknown column in where clause warning #379
Closed
@davidducos davidducos deleted the fix_374 branch July 16, 2021 12:42
@davidducos davidducos linked an issue Jul 19, 2021 that may be closed by this pull request
Segmentation fault error when using --rows option #381
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxbube maxbube maxbube approved these changes

Assignees
No one assigned
Labels
Fix
Projects
None yet
Milestone
Release 0.10.7-2
2 participants
@davidducos @maxbube