Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace WaitForCompletion with async logic #24

Merged
merged 3 commits into from
Dec 20, 2023

Conversation

joaoborks
Copy link
Member

No description provided.

@joaoborks joaoborks self-assigned this Dec 20, 2023
@joaoborks joaoborks linked an issue Dec 20, 2023 that may be closed by this pull request
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (3aac886) 87.93% compared to head (5d461c0) 87.78%.
Report is 1 commits behind head on main.

Files Patch % Lines
...loader/Runtime/Managers/SceneManagerAddressable.cs 88.88% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   87.93%   87.78%   -0.15%     
==========================================
  Files          18       18              
  Lines         779      778       -1     
==========================================
- Hits          685      683       -2     
- Misses         94       95       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaoborks joaoborks merged commit 3f87bc4 into main Dec 20, 2023
4 checks passed
joaoborks pushed a commit that referenced this pull request Dec 20, 2023
## [2.2.3](2.2.2...2.2.3) (2023-12-20)

### Bug Fixes

* replace WaitForCompletion with async logic ([#24](#24)) ([3f87bc4](3f87bc4))
@joaoborks
Copy link
Member Author

🎉 This PR is included in version 2.2.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Dec 20, 2023
## [2.2.3](2.2.2...2.2.3) (2023-12-20)

### Bug Fixes

* replace WaitForCompletion with async logic ([#24](#24)) ([3f87bc4](3f87bc4))
@joaoborks joaoborks deleted the fix/webgl-addressables branch December 26, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addressables support on WebGL
1 participant