Skip to content

Commit

Permalink
fix: add warning message for ng states
Browse files Browse the repository at this point in the history
  • Loading branch information
nb committed Jul 28, 2019
1 parent 8e7471e commit d45bae8
Show file tree
Hide file tree
Showing 28 changed files with 98 additions and 2 deletions.
3 changes: 3 additions & 0 deletions php/ng/apache2/ini.sls
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,8 @@
{% set settings = php.ini.defaults %}
{% do settings.update(php.apache2.ini.settings) %}
include:
- php.ng.deprecated
php_apache2_ini:
{{ php_ini(php.lookup.apache2.ini, php.apache2.ini.opts, settings) }}
1 change: 1 addition & 0 deletions php/ng/apache2/init.sls
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{% if grains['os_family'] in ["Debian", "FreeBSD"] %}
include:
- php.ng.deprecated
- php.ng.apache2.install
{% endif %} #END: os = Debian|FreeBSD
{% if grains['os_family'] == "Debian" %}
Expand Down
3 changes: 3 additions & 0 deletions php/ng/apache2/install.sls
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
{% from "php/ng/map.jinja" import php with context %}
include:
- php.ng.deprecated
{% set state = 'apache2' %}
{% include "php/ng/installed.jinja" %}
Expand Down
3 changes: 3 additions & 0 deletions php/ng/cli/ini.sls
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
{% from "php/ng/map.jinja" import php with context %}
{% from "php/ng/ini.jinja" import php_ini %}
include:
- php.ng.deprecated
{% set settings = php.ini.defaults %}
{% for key, value in php.cli.ini.settings.items() %}
{% if settings[key] is defined %}
Expand Down
1 change: 1 addition & 0 deletions php/ng/cli/init.sls
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Installs php-cli and manages the associated php.ini

include:
- php.ng.deprecated
- php.ng.cli.install
- php.ng.cli.ini

Expand Down
3 changes: 3 additions & 0 deletions php/ng/cli/install.sls
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
{% set state = 'cli' %}
{% include "php/ng/installed.jinja" %}

include:
- php.ng.deprecated

{%- if salt['grains.get']('os_family') == "Debian" %}
{% set current_php = salt['alternatives.show_current']('php') %}
{% set phpng_version = salt['pillar.get']('php:ng:version', '7.0')|string %}
Expand Down
1 change: 1 addition & 0 deletions php/ng/composer.sls
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
{% set salt_user_home = salt['user.info'](salt_user).get('home', '/root') %}
include:
- php.ng.deprecated
- php.ng
{% if grains['os_family'] == 'FreeBSD' %}
- php.ng.filter
Expand Down
40 changes: 40 additions & 0 deletions php/ng/deprecated.sls
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
# -*- coding: utf-8 -*-
# vim: ft=sls

{#- Evaluating as `False` by default, using this method since `defaults.yaml` not available in this repo #}
{%- if not salt['config.get']('php').get('warning_messages', {}).get('v1.0.0', {}).get('mute_upcoming', False) %}
php-deprecated-in-v1.0.0-test-succeed:
test.succeed_without_changes:
- name: |

################################################################################
# #
# WARNING: BREAKING CHANGES IN UPCOMING VERSION `v1.0.0` #
# #
################################################################################
# #
# This formula currently provides two methods for managing PHP; the old method #
# under `php` and the new method under `php.ng`. In upcoming `v1.0.0`, the old #
# method will be removed and `php.ng` will be promoted to `php` in its place. #
# #
# If you are not in a position to migrate, you will need to pin your repo to #
# the final release tag before `v1.0.0`, which is expected to be `v0.37.1`. #
# #
# If you are currently using `php.ng`, there is nothing to do until `v1.0.0` #
# is released. #
# #
# To migrate from the old `php`, the first step is to convert to `php.ng`, #
# before `v1.0.0` is released. #
# #
# To prevent this message being displayed again, set the pillar/config value: #
# #
# ``` #
# php: #
# warning_messages: #
# v1.0.0: #
# mute_upcoming: True #
# ``` #
# #
################################################################################
{%- endif %}
3 changes: 3 additions & 0 deletions php/ng/fpm/config.sls
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
{% from 'php/ng/map.jinja' import php with context %}
{% from "php/ng/ini.jinja" import php_ini %}
include:
- php.ng.deprecated
{% set ini_settings = php.ini.defaults %}
{% for key, value in php.fpm.config.ini.settings.items() %}
{% if ini_settings[key] is defined %}
Expand Down
1 change: 1 addition & 0 deletions php/ng/fpm/init.sls
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Meta-state to fully install php.fpm

include:
- php.ng.deprecated
- php.ng.fpm.config
- php.ng.fpm.service
- php.ng.fpm.pools
Expand Down
3 changes: 3 additions & 0 deletions php/ng/fpm/install.sls
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
include:
- php.ng.deprecated

{% set state = 'fpm' %}
{% include "php/ng/installed.jinja" %}
1 change: 1 addition & 0 deletions php/ng/fpm/pools.sls
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
{% endmacro %}
include:
- php.ng.deprecated
- php.ng.fpm.service
- php.ng.fpm.pools_config
Expand Down
3 changes: 3 additions & 0 deletions php/ng/fpm/pools_config.sls
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
{% from 'php/ng/map.jinja' import php with context %}
{% from "php/ng/macro.jinja" import sls_block, serialize %}
include:
- php.ng.deprecated
# Simple path concatenation.
{% macro path_join(file, root) -%}
{{ root ~ '/' ~ file }}
Expand Down
1 change: 1 addition & 0 deletions php/ng/fpm/service.sls
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
{% set service_function = {True:'running', False:'dead'}.get(php.fpm.service.enabled) %}
include:
- php.ng.deprecated
- php.ng.fpm.install
php_fpm_service:
Expand Down
3 changes: 3 additions & 0 deletions php/ng/hhvm/config.sls
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
{% from "php/ng/map.jinja" import php with context %}
{% from "php/ng/ini.jinja" import php_ini %}
include:
- php.ng.deprecated
{% set server_settings = php.lookup.hhvm.server %}
{% do server_settings.update(php.hhvm.config.server.settings) %}
Expand Down
1 change: 1 addition & 0 deletions php/ng/hhvm/init.sls
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Meta-state to fully install php.hhvm

include:
- php.ng.deprecated
- php.ng.hhvm.repo
- php.ng.hhvm.config
- php.ng.hhvm.service
Expand Down
3 changes: 3 additions & 0 deletions php/ng/hhvm/install.sls
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
include:
- php.ng.deprecated

{% set state = 'hhvm' %}
{% include "php/ng/installed.jinja" %}
1 change: 1 addition & 0 deletions php/ng/hhvm/repo.sls
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
{% from "php/ng/map.jinja" import php with context %}
include:
- php.ng.deprecated
- php.ng.hhvm.install
Expand Down
3 changes: 2 additions & 1 deletion php/ng/hhvm/service.sls
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
{% set service_function = {True:'running', False:'dead'}.get(php.hhvm.service.enabled) %}
include:
- php.ng.deprecated
- php.ng.hhvm.install
php_hhvm_service:
Expand All @@ -15,5 +16,5 @@ php_hhvm_service:
- require:
- sls: php.ng.hhvm.install
- watch:
- pkg: php_install_hhvm
- pkg: php_install_hhvm
4 changes: 3 additions & 1 deletion php/ng/installed.jinja
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
{% from "php/ng/map.jinja" import php with context %}
{% from "php/ng/macro.jinja" import sls_block %}

include:
- php.ng.deprecated

{% set pkginfo = php.lookup.pkgs.get(state) %}

Expand Down Expand Up @@ -60,7 +62,7 @@ php_ppa_{{ state }}:
- __env__:
- LC_ALL: C.UTF-8
- onlyif:
- test ! -e /etc/apt/sources.list.d/ondrej-php.list
- test ! -e /etc/apt/sources.list.d/ondrej-php.list
- require_in:
- pkg: php_install_{{ state }}
pkg.latest:
Expand Down
3 changes: 3 additions & 0 deletions php/ng/mdb2/init.sls
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
include:
- php.ng.deprecated

{% set state = 'mdb2' %}
{% include "php/ng/installed.jinja" %}
3 changes: 3 additions & 0 deletions php/ng/mdb2/mysql.sls
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
include:
- php.ng.deprecated

{% set state = 'mdb2-driver-mysql' %}
{% include "php/ng/installed.jinja" %}
{% include "php/ng/mdb2/init.sls" %}
3 changes: 3 additions & 0 deletions php/ng/mdb2/pgsql.sls
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
include:
- php.ng.deprecated

{% set state = 'mdb2-driver-pgsql' %}
{% include "php/ng/installed.jinja" %}
{% include "php/ng/mdb2/init.sls" %}
1 change: 1 addition & 0 deletions php/ng/suhosin.sls
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{% from "php/ng/map.jinja" import php with context %}
include:
- php.ng.deprecated
- php.ng
- php.ng.dev
Expand Down
3 changes: 3 additions & 0 deletions php/ng/xcache/ini.sls
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
{% from "php/ng/map.jinja" import php with context %}
{% from "php/ng/ini.jinja" import php_ini %}
include:
- php.ng.deprecated
{% set settings = php.xcache.ini.defaults %}
{% for key, value in php.xcache.ini.settings.items() %}
{% if settings[key] is defined %}
Expand Down
1 change: 1 addition & 0 deletions php/ng/xcache/init.sls
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Installs php-xcache and manages the associated xcache.ini

include:
- php.ng.deprecated
- php.ng.xcache.install
- php.ng.xcache.ini

Expand Down
3 changes: 3 additions & 0 deletions php/ng/xcache/install.sls
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
include:
- php.ng.deprecated

{% set state = 'xcache' %}
{% include "php/ng/installed.jinja" %}
1 change: 1 addition & 0 deletions pillar.example
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ php:
warning_messages: #
v1.0.0: #
mute_critical: True #
mute_upcoming: True #
# Use external repository instead the default (only Ubuntu family)
use_external_repo: True
# Set the external repository name (valid only if use_external_repo is not none)
Expand Down

0 comments on commit d45bae8

Please sign in to comment.