feat(template): review PRs 212 & 223 (inc. preparing for propagation) #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
myii
commented
Feb 11, 2021
•
myii
commented
- style(inspec): match current practices for file and control names saltstack-formulas/template-formula#212
- chore(git): add visual studio to gitignore saltstack-formulas/template-formula#223
Use `:r! find ssf/files/ -name .gitignore` to locate all of the templates to merge.
* saltstack-formulas/template-formula#212 Use `:r! grep -riIn _mapdata_spec` to locate all of the lines to be adjusted. Then fix with `%s:_mapdata_spec.rb:_mapdata.rb:` (check changes carefully afterwards). Use `:r! find ssf/files/ -name _mapdata_spec.rb` to locate all of the templates to rename and adjust.
myii
force-pushed
the
feat/review-PR-for-XYZ-formula
branch
from
761e5b9
to
327a29e
Compare
myii
added a commit
to saltstack-formulas/apache-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/apt-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/apt-cacher-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/arvados-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/bind-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/cert-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/chrony-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/collectd-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/consul-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/cron-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/deepsea-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/devstack-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/dhcpd-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/django-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/docker-formula
that referenced
this pull request
Feb 11, 2021
19 tasks
myii
added a commit
to saltstack-formulas/eclipse-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/epel-formula
that referenced
this pull request
Feb 11, 2021
19 tasks
myii
added a commit
to saltstack-formulas/exim-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/fail2ban-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/firewalld-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/golang-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/grafana-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/haproxy-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/redis-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/rkhunter-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/rng-tools-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/rspamd-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/salt-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/sqldeveloper-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/sqlplus-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/strongswan-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/stunnel-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/sudoers-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/suricata-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/sysctl-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/syslog-ng-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/sysstat-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/systemd-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/telegraf-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/template-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/timezone-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/tomcat-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/ufw-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/users-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/varnish-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/vault-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/vim-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/vsftpd-formula
that referenced
this pull request
Feb 11, 2021
myii
added a commit
to saltstack-formulas/zabbix-formula
that referenced
this pull request
Feb 11, 2021
|
🎉 This PR is included in version 1.243.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.