Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reflected exclude option when use glob #44

Merged
merged 2 commits into from
Jan 18, 2019

Conversation

sh4869
Copy link
Contributor

@sh4869 sh4869 commented Jan 7, 2019

When use --exclude option and glob pattern (ex: test/**.py) , exclude option is not reflected. I think exclude option should be reflected when specify files as same as specify folder.

@sh4869 sh4869 changed the title apply exclude option when use glob reflected exclude option when use glob Jan 7, 2019
@coveralls
Copy link

coveralls commented Jan 7, 2019

Coverage Status

Coverage increased (+0.006%) to 99.537% when pulling 1ef0fb1 on sh4869:fix/exlucde-on-glob into 9fe7aae on myint:master.

@myint
Copy link
Member

myint commented Jan 13, 2019

Sounds good to me.

Please add a unit test for this functionality. Thanks!

@sh4869
Copy link
Contributor Author

sh4869 commented Jan 16, 2019

I added a unit test for is_exclude_file.

@myint myint merged commit 5130533 into PyCQA:master Jan 18, 2019
@sh4869 sh4869 deleted the fix/exlucde-on-glob branch January 19, 2019 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants