Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I don't think it takes global functions into account #92

Closed
JesseJ opened this issue Feb 24, 2016 · 1 comment
Closed

I don't think it takes global functions into account #92

JesseJ opened this issue Feb 24, 2016 · 1 comment

Comments

@JesseJ
Copy link

JesseJ commented Feb 24, 2016

One of the messages that I got is

calcfinesstrategy.h:6: 'dates.h' does not need to be #included

Which is wrong, since removing it will result in a compiler error. Below is a simplified example.

calcfinesstrategy.h:

ifndef CALCFINESSTRATEGY_H

define CALCFINESSTRATEGY_H

include "dates.h"

class CCCalcFinesStrategy
{
public:
CCCalcFinesStrategy();
private:
void Initialize();
};

endif`

calcfinesstrategy.cpp:

include "calcfinesstrategy.h"

void CCCalcFinesStrategy::Initialize()
{
current_date_time( var1, var2, var3, 1 );
}

dates.h:

ifndef DATES_H

define DATES_H

int current_date_time( long long &f_ts, wchar_t *sa_date, long &d_dayno, int i_format );

endif

@myint
Copy link
Owner

myint commented Feb 24, 2016

I think dates.h ought to be included in calcfinesstrategy.cpp (rather than in calcfinesstrategy.h).

@myint myint closed this as completed Feb 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants