Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type ignore comments is a false positive. #15

Closed
proofit404 opened this issue Oct 9, 2019 · 2 comments · Fixed by #27 or #33
Closed

Type ignore comments is a false positive. #15

proofit404 opened this issue Oct 9, 2019 · 2 comments · Fixed by #27 or #33
Labels
enhancement help wanted

Comments

@proofit404
Copy link

Write # type: ignore at the beginning of the file will be considered by this plugin as dead code.

Initially reported to wemake-services/flake8-eradicate#68
@uhbif19 uhbif19 mentioned this issue Nov 20, 2019
Closed
This was referenced Jun 9, 2020
Closed
Merged
@proofit404
Copy link
Author

@sobolevn Thanks for fixing it!

# isort: skip did the same as well unfortunately.

@sobolevn
Copy link
Member

sobolevn commented Sep 4, 2020

@proofit404 can you please add isort to the whitelist?

@sobolevn sobolevn reopened this Sep 4, 2020
@Cielquan Cielquan mentioned this issue Mar 31, 2022
Merged
sobolevn pushed a commit that referenced this issue Apr 1, 2022
@Cielquan
add isort action comments to whitelist (#33)
1f98dc4 
* add isort action comments to whitelist

fixes #15 (comment)

* add tests for isort whitelist addition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

added whitelisting
add isort action comments to whitelist
3 participants
@myint @proofit404 @sobolevn