Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current day's high/lows #8

Closed
humdinger44 opened this issue May 27, 2020 · 2 comments
Closed

Current day's high/lows #8

humdinger44 opened this issue May 27, 2020 · 2 comments

Comments

@humdinger44
Copy link

Hi. Love the module and I've been using it for a long time. My only complaint is that the forecast section starts with tomorrow. There is no information displayed for the current day's high/low, just the current conditions. If it is 75 degs at 10 am, is it going to stay at 75 all day or is the high 95? I have to go elsewhere to figure that out or try to remember what the module said yesterday.

Cheers

@humdinger44
Copy link
Author

humdinger44 commented May 27, 2020

in mmm-bmw-ds.js there are two sections that look like this

        moment.unix(forecast.daily.data[0].time).local().format('ddd') + " &nbsp" + "<img class = image src=./modules/MMM-BMW-DS/icons/" + forecast.daily.data[0].icon + ".png>" + " &nbsp" + Math.round(forecast.daily.data[0].temperatureHigh) + "/" + Math.round(forecast.daily.data[0].temperatureLow) + " &nbsp &nbsp  &nbsp &nbsp &nbsp" +

for both sections, taking all the numbers in brackets and lowering them by 1 ( [1] -> [0] )starts the forecast at the current day!

@mykle1
Copy link
Owner

mykle1 commented May 29, 2020

in mmm-bmw-ds.js there are two sections that look like this

        moment.unix(forecast.daily.data[0].time).local().format('ddd') + " &nbsp" + "<img class = image src=./modules/MMM-BMW-DS/icons/" + forecast.daily.data[0].icon + ".png>" + " &nbsp" + Math.round(forecast.daily.data[0].temperatureHigh) + "/" + Math.round(forecast.daily.data[0].temperatureLow) + " &nbsp &nbsp  &nbsp &nbsp &nbsp" +

for both sections, taking all the numbers in brackets and lowering them by 1 ( [1] -> [0] )starts the forecast at the current day!

Done. You could send a PR next time haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants