Skip to content

Commit

Permalink
Bug 1526627 [wpt PR 15256] - [html] Restore coverage for query encodi…
Browse files Browse the repository at this point in the history
…ng, a=testonly

Automatic update from web-platform-tests
HTML: restore coverage for query encoding

When the query encoding navigation tests were refactored to use WPT's
"variant" feature [1], the new structure omitted one of the encodings
which was previously tested. Although the encoding will be used when a
variant is not specified, the automation tooling only uses variants
which are explicitly specified. This can be observed through the
`--list-tests` flag of the `wpt run` command:

    $ ./wpt run --list-tests firefox html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html
    /html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=utf8
    /html/infrastructure/urls/resolving-urls/query-encoding/navigation.sub.html?encoding=x-cp1251

Explicitly declare the default variant, restoring the original test
coverage.

[1] web-platform-tests/wpt#11300
--

wpt-commits: 0b594535b4d94217964a40288e3f535c452bb8f3
wpt-pr: 15256
  • Loading branch information
jugglinmike authored and moz-wptsync-bot committed Feb 21, 2019
1 parent ed637d4 commit d1196f0
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
@@ -1,5 +1,6 @@
<!doctype html>
<meta charset={{GET[encoding]}}> <!-- ends up as <meta charset> by default which is windows-1252 -->
<meta name=variant content="?encoding=windows-1252">
<meta name=variant content="?encoding=x-cp1251">
<meta name=variant content="?encoding=utf8">
<script src=/resources/testharness.js></script>
Expand Down
@@ -1,5 +1,6 @@
<!doctype html>
<meta charset={{GET[encoding]}}> <!-- ends up as <meta charset> by default which is windows-1252 -->
<meta name=variant content="?encoding=windows-1252">
<meta name=variant content="?encoding=x-cp1251">
<meta name=variant content="?encoding=utf8">
<script src=/resources/testharness.js></script>
Expand Down
@@ -1,5 +1,6 @@
<!doctype html>
<meta charset={{GET[encoding]}}> <!-- ends up as <meta charset> by default which is windows-1252 -->
<meta name=variant content="?encoding=windows-1252">
<meta name=variant content="?encoding=x-cp1251">
<meta name=variant content="?encoding=utf8">
<script src=/resources/testharness.js></script>
Expand Down

0 comments on commit d1196f0

Please sign in to comment.