Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Luhn algorithm is not implemented correctly #15

Closed
MylesFTOP opened this issue Mar 15, 2020 · 0 comments · Fixed by #17
Closed

Luhn algorithm is not implemented correctly #15

MylesFTOP opened this issue Mar 15, 2020 · 0 comments · Fixed by #17
Assignees
@MylesFTOP
Labels
bug Something isn't working

Comments

@MylesFTOP
Copy link
Owner

Currently, the checksum algorithm implemented is a combination of digit sum (including doubling every other digit in the digit sum), and then a final digit sum to reduce the output to a single digit, but the Luhn algorithm itself includes functions to find the remainder of a mod 10 function (or to achieve a remainder of 0 from a mod 10 function). The function will need to be rewritten to implement this correctly.
@MylesFTOP MylesFTOP added the bug Something isn't working label Mar 15, 2020
@MylesFTOP MylesFTOP self-assigned this Mar 15, 2020
@MylesFTOP MylesFTOP linked a pull request May 17, 2020 that will close this issue
Algorithm correction - fixes #15 #17
Merged
MylesFTOP added a commit that referenced this issue May 17, 2020
@MylesFTOP
Merge pull request #17 from MylesFTOP/algorithm-correction
de20b4d 
Algorithm correction - fixes #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MylesFTOP MylesFTOP

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Algorithm correction - fixes #15 MylesFTOP/LuhnCheck
1 participant
@MylesFTOP