Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package not compatible with next version of tzlocal #166

Open
pganssle opened this issue Sep 21, 2020 · 1 comment
Open

Package not compatible with next version of tzlocal #166

pganssle opened this issue Sep 21, 2020 · 1 comment

Comments

@pganssle
Copy link

The next version of tzlocal will switch from using pytz zones to zoneinfo (which is generally a good idea), which will break this package, since zoneinfo zones don't have the same interface as pytz zones.

You should probably pin the version of tzlocal ASAP, and/or add in some logic to detect zoneinfo zones and convert them to whatever you want (at least this line will break, for example).

In the longer term, you should probably also migrate away from pytz and on to zoneinfo. I have a pytz-deprecation-shim module that should help ease the pain (though it is not 100% backwards compatible - in the migration guide you'll find that the semantics of datetime addition are slightly different).

xzkostyan added a commit that referenced this issue Aug 18, 2021
xzkostyan added a commit that referenced this issue Aug 18, 2021
@xzkostyan
Copy link
Member

tzlocal>=3.0 support is merged into master. I need to check zoneinfo performance before migrating to it from pytz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants