New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed multidimensional array decode error #206
fixed multidimensional array decode error #206
Conversation
CI/CD failed: https://travis-ci.org/github/mymarilyn/clickhouse-driver/builds/765826137. Please add test from issue to array testcase to cover this case. It would be nice if we ensure that array column performance will not be degraded. To test it you can query array column with old version and new version of code You can use following query for example (tune limit if it's necessary): select arrayJoin(x), x from (select groupArray(number) as x from (select * from system.numbers limit 10000) as t) To measure performance you can run from clickhouse_driver import Client
client = Client('localhost')
%prun client.execute(sql) |
@xzkostyan, how can I run test suite locally against local Clickhouse at port 9000? Is it a correct way : setup.py test ? |
|
sql = "select arrayJoin(x), x from (select groupArray(number) as x from (select * from system.numbers limit 10000) as t)"
from clickhouse_driver import Client
client = Client(host='localhost', port='9000', database='default', user='default', password='default')
%prun client.execute(sql) with new code
with old code
New version looks better |
Why do you python-folks hate semicolon so much? |
Looks like LowCardinality encoder is broken for 18.* (test_multidimensional passes without LowCardinality spec, at least with 18.12.17 db)
|
Ok, maybe unsupported LowCardinality is OK, found that in logs:
|
Good job! |
@xzkostyan Thank you! |
This PR should fix #204