Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-cythonize files via cythonize -3 #342

Merged
merged 2 commits into from
Nov 1, 2022
Merged

re-cythonize files via cythonize -3 #342

merged 2 commits into from
Nov 1, 2022

Conversation

asottile-sentry
Copy link
Contributor

see also #341

  • fixes #

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Ensure PR doesn't contain untouched code reformatting: spaces, etc.
  • Run flake8 and fix issues.
  • Run pytest no tests failed. See https://clickhouse-driver.readthedocs.io/en/latest/development.html.

@xzkostyan
Copy link
Member

Thanks for PR. To make tests green we need to install newer coverage version and re-cythonize clickhouse-cityhash. I'm stuck in the last thing. It seems that upstream is not ready for 3.11 yet: escherba/python-cityhash#73.

Draft branch with changes for 3.11: master...wheels-for-3.11

@asottile-sentry
Copy link
Contributor Author

the call to coverage uses the old py.test name rather than pytest -- want to cherry pick my latest commit here into your branch? it'll likely get further

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.504% when pulling 6cb3590 on asottile-sentry:re-cythonize into e815179 on mymarilyn:master.

@xzkostyan xzkostyan merged commit 3d8cfc6 into mymarilyn:master Nov 1, 2022
@asottile-sentry asottile-sentry deleted the re-cythonize branch October 2, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants