Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed memory leak when clickhouse raise error on data send. #407

Conversation

pulina
Copy link
Contributor

@pulina pulina commented Dec 12, 2023

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change. # I did not spoot any test for cython code
  • Add or update relevant docs, in the docs folder and in code. # Non required
  • Ensure PR doesn't contain untouched code reformatting: spaces, etc.
  • Run flake8 and fix issues. # to much issues to fix XD but as far as i can tell no issue added
  • Run pytest no tests failed. See https://clickhouse-driver.readthedocs.io/en/latest/development.html.

@pulina pulina changed the title Fixed memory leek when clickhouse raise error on data send. Fixed memory leak when clickhouse raise error on data send. Dec 12, 2023
@coveralls
Copy link

Coverage Status

coverage: 96.091%. remained the same
when pulling 5d1b6e6 on pulina:Fixed_memory_leek_when_clickhouse_raise_error_on_data_send
into f088802 on mymarilyn:master.

@xzkostyan xzkostyan merged commit 194bf06 into mymarilyn:master Dec 12, 2023
378 of 396 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak when clickhouse raise error on data send.
3 participants