fix: log2ram can't stop before it's installed #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue with `setup/setup_device.sh` where log2ram service would try to stop before log2ram was installed. I copied the log2ram logic from `rootfs/standard/usr/bin/mynode_post_upgrade.sh` as it looks like it functions correctly. In the future I think we should add a feature to disable log2ram since it is really only needed when you are running on an sdcard or USB, but that will be for another day.
tehelsper
approved these changes
Aug 8, 2024
|
Thanks. Setup_device.sh only should run once when making new images, but this would prevent re-installs from happening if the script failed and had to be re-run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with
setup/setup_device.shwhere log2ram service would try to stop before log2ram was installed. I copied the log2ram logic fromrootfs/standard/usr/bin/mynode_post_upgrade.shas it looks like it functions correctly.This is a fix for log2ram not working, and why I opened #868
Checklist
List of test device(s)
x86 Debian 12 VM on Proxmox.