Support recv method on hook #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any update ? |
myood
requested changes
Nov 25, 2023
| @@ -62,6 +62,34 @@ impl Hook { | |||
| pub fn try_recv(&self) -> Result<InputEvent, std::sync::mpsc::TryRecvError> { | |||
| InnerHook::try_recv() | |||
| } | |||
|
|
|||
| /// Hook::recv() should be an option besides Hook::try_recv() when you want park the current thread until there is an event to process. | |||
There was a problem hiding this comment.
Please reword description so that this doc does sound like statement and does not duplicate try_recv() example.
Maybe
This is blocking alternative to Hook::try_recv(). That is it will block the current thread until there is an event from the low-level hook(s) running in the background thread(s), and then will return it.
| @@ -14,6 +14,13 @@ mod keyboard_hook_tests { | |||
| use willhook::event::IsSystemKeyPress::*; | |||
| use mki::Keyboard; | |||
|
|
|||
| #[test] | |||
There was a problem hiding this comment.
Please expand the test before merging.
Test like this would suffice:
imitate key press
imitate other key press
imitate mouse button
imitate mouse move
recv() accordingly to drain all events
call try_recv() to validate the events queue is empty
Dedicated file "blocking.rs" would be good.
| /// } | ||
| /// # } | ||
| /// ``` | ||
| pub fn recv(&self) -> Result<InputEvent, std::sync::mpsc::RecvError> { |
There was a problem hiding this comment.
You should mention this new method in lib.rs doc.
|
feel free to change it, or close it, we have changed impl to windows-rs |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support hook recv method to avoid circular loops, sleeps, thread yielding and cpu miss cycles when try_recv is used