Don't link to gettext's private libgettextlib #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not needed, and functions from the portion of glib included within may not be compatible with the functions provided by the system's full version of glib, which may result in a crash like mypaint/mypaint#114
|
Interesting! Were we previously just frivolously linking to libgettext without using it at all? |
|
I was not able to find a description of libgettextlib, but I believe it to be a library intended only for the use of the programs that ship with gettext. |
|
Huh, so this completely broke Mypaint for some OS X installs? I'll merge this in and hope it doesn't break anything, thank you for finding and fixing this! |
iirelu
added a commit
that referenced
this pull request
Dec 28, 2014
Don't link to gettext's private libgettextlib
|
Yes, MyPaint crashed immediately on launch for me under OS X v10.10 Yosemite, until I made this change. I don't know what's in libgettextlib, but I assume it's of no interest to anyone other than gettext's own programs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not needed, and functions from the portion of glib included within may not be compatible with the functions provided by the system's full version of glib, which may result in a crash like mypaint/mypaint#114