Fix off by one error when clearing smudge buckets #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The max_buckets_used value is _inclusive_, so an additional +1 is necessary to clear the last used bucket.
askmeaboutlo0m
added a commit
to askmeaboutlo0m/Drawpile
that referenced
this pull request
Aug 15, 2022
There's an off by one error there. A PR against libmypaint has also been opened, but presumably they won't backport it to the stable 1.6.1: mypaint/libmypaint#186
askmeaboutlo0m
added a commit
to askmeaboutlo0m/Drawpile
that referenced
this pull request
Aug 15, 2022
There's an off by one error there. A PR against libmypaint has also been opened, but presumably they won't backport it to the stable 1.6.1: mypaint/libmypaint#186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
max_buckets_usedvalue is inclusive, so an additional +1 is necessary to clear the last used bucket.