Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent camel cased options from breaking order detail page #838

Conversation

joerivanveen
Copy link
Contributor

@joerivanveen joerivanveen commented Apr 16, 2024

Needs myparcelnl/sdk#481

INT-449

@joerivanveen joerivanveen marked this pull request as ready for review April 16, 2024 12:58
@joerivanveen joerivanveen requested a review from a team as a code owner April 16, 2024 12:58
@joerivanveen joerivanveen marked this pull request as draft April 16, 2024 13:12
@joerivanveen joerivanveen force-pushed the fix/prevent-camel-cased-options-from-breaking-order-detail-page branch from a239156 to 307efe8 Compare April 18, 2024 19:03
@joerivanveen joerivanveen marked this pull request as ready for review April 18, 2024 19:05
Block/Sales/View.php Outdated Show resolved Hide resolved
Block/Sales/View.php Outdated Show resolved Hide resolved
Block/Sales/View.php Show resolved Hide resolved
RichardPerdaan
RichardPerdaan previously approved these changes Apr 22, 2024
@joerivanveen joerivanveen force-pushed the fix/prevent-camel-cased-options-from-breaking-order-detail-page branch from e8c97eb to 16ff9e2 Compare April 22, 2024 08:58
@RichardPerdaan RichardPerdaan merged commit bc8cff4 into develop Apr 22, 2024
1 check passed
@RichardPerdaan RichardPerdaan deleted the fix/prevent-camel-cased-options-from-breaking-order-detail-page branch April 22, 2024 13:03
MyParcelBot pushed a commit that referenced this pull request Apr 22, 2024
## [4.14.3](v4.14.2...v4.14.3) (2024-04-22)

### 🐛 Bug Fixes

* **checkout:** work with bbp and do6 from cdn ([#837](#837)) ([c560351](c560351))
* prevent camel cased options from breaking order detail page ([#838](#838)) ([bc8cff4](bc8cff4))
@MyParcelBot
Copy link

🎉 This PR is included in version 4.14.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants