Compatible with Laravel 7 #230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: PHP Fatal error: Declaration of MyParcelNL\Sdk\src\Support\Collection::when($value, callable $callback, ?callable $default = NULL) must be compatible with Illuminate\Support\Collection::when($value, ?callable $callback = NULL, ?callable $default = NULL) in /Users/jasonhoendervanger/PhpstormProjects/deraad/vendor/myparcelnl/sdk/src/Support/Collection.php on line 38
|
Is it possible to get this merged? My application update is being held back because of this issue. |
RichardPerdaan
approved these changes
May 22, 2020
|
This is already fixed in #225? |
yes |
|
I still seem to have this issue, not sure if you guys tried this but it has not been solved for me. Using version 4. |
|
Just checked, if you use version 4 the collection is not updated properly: sdk/src/Support/Collection.php Line 486 in ce167d0 It is still the old function. |
|
On this moment we work on v4.1.0. I expect to set this version live today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
PHP Fatal error: Declaration of MyParcelNL\Sdk\src\Support\Collection::when($value, callable $callback, ?callable $default = NULL) must be compatible with Illuminate\Support\Collection::when($value, ?callable $callback = NULL, ?callable $default = NULL) in /vendor/myparcelnl/sdk/src/Support/Collection.php on line 38