Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use native_int instead of int64/int32 in IR test output #776

Closed
JukkaL opened this issue Nov 4, 2020 · 1 comment
Closed

Use native_int instead of int64/int32 in IR test output #776

JukkaL opened this issue Nov 4, 2020 · 1 comment
Labels
enhancement Improvements to existing logic or features. priority-0-high

Comments

@JukkaL
Copy link
Collaborator

JukkaL commented Nov 4, 2020

Copy-pasting IR build test output often results in CI failures, since the output may contain types like int64, which are platform-dependent -- and should be native_int. This causes the 32-bit Windows build to fail.

native_int seems to be almost always what we want, so I'd suggest replacing int64/int32 in test output with native_int. This will also make it easier to bulk update test cases if there are changes in the generated IR.

So instead of having to manually replace int64 with native_int, we'll sometimes need to replace native_int with int64. This seems like a good trade-off.

@TH3CHARLie
Copy link
Collaborator

TH3CHARLie commented May 8, 2021

Raising priority as more and more mypyc contributors are facing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing logic or features. priority-0-high
Projects
None yet
Development

No branches or pull requests

2 participants