[mypyc] Emit native_int instead of int64/int32 in IR test output - #10446
Merged
Conversation
TH3CHARLie
marked this pull request as draft
May 8, 2021 07:13
TH3CHARLie
marked this pull request as ready for review
May 8, 2021 08:05
Collaborator
|
lgtm |
JukkaL
approved these changes
May 25, 2021
JukkaL
left a comment
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Very nice! Confusion between different integer types in tests has been a common pain point. This will reduce friction when writing new features and changing the generated IR significantly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates mypyc/mypyc#776
This is a super quick workaround. So far the issue mostly (if not completely) occurs in
c_pyssize_tso making this rtype emitsnative_intwould solve the issue. As a result, thereplace_native_intpass in IR test is now removed.