Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate most uses of INVALID_VALUE #272

Merged
merged 2 commits into from Jul 17, 2018
Merged

Eliminate most uses of INVALID_VALUE #272

merged 2 commits into from Jul 17, 2018

Conversation

msullivan
Copy link
Collaborator

No description provided.

@msullivan msullivan requested a review from hughhan1 July 17, 2018 20:57
hughhan1
hughhan1 approved these changes Jul 17, 2018
View reviewed changes
Copy link
Contributor

@hughhan1 hughhan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This makes it so that we don't have a bunch of meaningless INVALID_VALUEs being returned when we can return None. 😄

hughhan1
hughhan1 approved these changes Jul 17, 2018
View reviewed changes
Copy link
Contributor

@hughhan1 hughhan1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! This makes it so that we don't have a bunch of meaningless INVALID_VALUEs being returned when we can return None. 😄

@msullivan msullivan merged commit 3b5c7e5 into master Jul 17, 2018
@msullivan msullivan deleted the visitor branch July 17, 2018 21:51
msullivan added a commit to python/mypy that referenced this pull request Aug 20, 2019
@msullivan
Eliminate most uses of INVALID_VALUE (mypyc/mypyc#272)
fd1ed21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughhan1 hughhan1 hughhan1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@msullivan @hughhan1