Fix singleRX example to work correctly with LimeSDR Mini V2 #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue this commit fixes is that running singleRX example does not show any samples streaming, and logs shows: RX data rate: 0 MB/s. The fix follows the initialization order in basicRX.cpp where the TX channel is enabled alongside with the RX channel right after the LMS_Init(). With this fix running singleRX example shows samples streamed: RX data rate: 32.1454 MB/s. This is a bit counter-intuitive API from developers perspective (as in, intuitively question is why TX channel is needed for RX-only application). So it does feel like that perhaps the fix needs to be done somewhere deeper in the driver or in gateware to increase clarity of API. However, that'd be a deeper change, if it happens. In any case, until such possible change the proposal is to fix the issue in the same way as it is done in the other example. The motivation to get the example fixed is because this is something that new LimeSDR users run into as some of their first steps, so having examples properly working solves initial confusion and possible frustration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue this commit fixes is that running singleRX example does not show any samples streaming, and logs shows: RX data rate: 0 MB/s.
The fix follows the initialization order in basicRX.cpp where the TX channel is enabled alongside with the RX channel right after the LMS_Init(). With this fix running singleRX example shows samples streamed: RX data rate: 32.1454 MB/s.
This is a bit counter-intuitive API from developers perspective (as in, intuitively question is why TX channel is needed for RX-only application). So it does feel like that perhaps the fix needs to be done somewhere deeper in the driver or in gateware to increase clarity of API. However, that'd be a deeper change, if it happens. In any case, until such possible change the proposal is to fix the issue in the same way as it is done in the other example.
The motivation to get the example fixed is because this is something that new LimeSDR users run into as some of their first steps, so having examples properly working solves initial confusion and possible frustration.